Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go vet etl to check etl dependencies #146

Merged
merged 1 commit into from
Jul 8, 2019
Merged

add go vet etl to check etl dependencies #146

merged 1 commit into from
Jul 8, 2019

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Jul 6, 2019 •
edited by stephen-soltesz
Loading

etl now depends on ndt-server. This adds go vet on the etl repo to ensure we don't break it.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Jul 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 798

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.237%
Totals Coverage Status
Change from base Build 786: 0.2%
Covered Lines: 1412
Relevant Lines: 1928
💛 - Coveralls

bassosimone
bassosimone approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@gfr10598 gfr10598 merged commit e64c572 into master Jul 8, 2019
@gfr10598 gfr10598 deleted the vet-etl branch July 8, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gfr10598 @coveralls @bassosimone