Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndt7/d/s/sender.go: remove unused variable #204

Merged
merged 1 commit into from
Oct 14, 2019
Merged

ndt7/d/s/sender.go: remove unused variable #204

merged 1 commit into from
Oct 14, 2019

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Oct 14, 2019 •
edited by stephen-soltesz
Loading

This change is Reviewable

@bassosimone bassosimone self-assigned this Oct 14, 2019
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1042

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.6%) to 79.503%
Files with Coverage Reduction New Missed Lines %
ndt5/protocol/messager.go 2 87.76%
ndt5/protocol/protocol.go 4 83.78%
ndt5/s2c/s2c.go 6 53.85%
Totals Coverage Status
Change from base Build 1040: -0.6%
Covered Lines: 1567
Relevant Lines: 1971
💛 - Coveralls

pboothe
pboothe approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bassosimone bassosimone merged commit eb2541c into master Oct 14, 2019
@bassosimone bassosimone deleted the fix/remove-unused-line branch October 14, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboothe pboothe pboothe approved these changes

Assignees

@bassosimone bassosimone

Labels
review/triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bassosimone @coveralls @pboothe