Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attempted fix for #211 #212

Merged
merged 1 commit into from
Oct 30, 2019
Merged

attempted fix for #211 #212

merged 1 commit into from
Oct 30, 2019

Conversation

critzo
Copy link

@critzo critzo commented Oct 29, 2019 •
edited by stephen-soltesz
Loading

This is an untested draft PR attempting to fix #211 @pboothe PTAL?

This change is Reviewable

@critzo critzo requested a review from pboothe October 29, 2019 16:45
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1053

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.8%) to 79.112%
Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 72.32%
ndt5/protocol/messager.go 2 87.76%
ndt5/protocol/protocol.go 4 83.78%
ndt7/upload/sender/sender.go 5 67.65%
ndt5/s2c/s2c.go 6 53.04%
Totals Coverage Status
Change from base Build 1051: -0.8%
Covered Lines: 1568
Relevant Lines: 1982
💛 - Coveralls

@pboothe pboothe marked this pull request as ready for review October 29, 2019 21:49
@pboothe
Copy link
Contributor

pboothe commented Oct 29, 2019

LGTM

@critzo critzo merged commit 437ec3b into master Oct 30, 2019
@critzo critzo mentioned this pull request Oct 30, 2019
Closed
@bassosimone bassosimone deleted the fullstack-fix-#211 branch October 30, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pboothe pboothe pboothe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full stack dockerfile start.sh script should check for prefix file before trying to create it
3 participants
@critzo @coveralls @pboothe