UUIDs are now in tmpfiles #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded since we're using /tmp/
|
@pboothe Thanks for that. I tested and confirmed this is working. I also made an additional commit to remove the "if prefix file exists" check. It was keeping filenames from including hostnames. I tested this to confirm it worked as expected, but please feel free to cross-validate. |
|
Thanks! Let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some thought last night, I realized we moved the codebase in the wrong direction. Instead, the UUID prefix should be in a file in
/tmpand be recreated on every run. Keeping the old file around puts the uniqueness of the UUIDs at risk.This change is