Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndt7: start refactoring to reduce the number of channels #248

Merged
merged 6 commits into from
Feb 11, 2020

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Feb 4, 2020

As documented in #238, we would like to reduce the pipeline
structure and the dependency on channels. We have a reasonably
clear idea of what we want to do.

Let us do this piecemeal.

In this first diff, I'm changing the measurer to be a
struct rather than just a func. By doing that, I'm
creating the opportunity for storing the measurements
collected by the measurer into the measurer itself rather
than publishing them downstream to a channel.


This change is Reviewable

As documented in #238, we would like to reduce the pipeline
structure and the dependency on channels. We have a reasonably
clear idea of what we want to do.

Let us do this piecemeal.

In this first diff, I'm changing the measurer to be a
struct rather than just a func. By doing that, I'm
creating the opportunity for storing the measurements
collected by the measurer into the measurer itself rather
than publishing them downstream to a channel.
@bassosimone bassosimone added enhancement 2020-02-meeting To discuss during 2020-02-meeting labels Feb 4, 2020
@bassosimone bassosimone self-assigned this Feb 4, 2020
Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pboothe)

@coveralls
Copy link
Collaborator

coveralls commented Feb 10, 2020

Pull Request Test Coverage Report for Build 1189

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.942%

Files with Coverage Reduction New Missed Lines %
ndt7/upload/sender/sender.go 3 67.65%
Totals Coverage Status
Change from base Build 1187: -0.02%
Covered Lines: 1654
Relevant Lines: 2069

💛 - Coveralls

@bassosimone bassosimone merged commit 583f804 into master Feb 11, 2020
@bassosimone bassosimone deleted the issue/238 branch February 11, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2020-02-meeting To discuss during 2020-02-meeting enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants