ndt7: always include ConnectionInfo #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed how annoying is not doing that with @robertodauria during the review of m-lab/ndt7-client-go#39. As part of such work, we also double checked that every TCPInfo field described by the spec is a meaningful ndt7 summary. As a result we can now close #194.
Pull Request Test Coverage Report for Build 1200
💛 - Coveralls |
pboothe
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @pboothe and @robertodauria)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed how annoying is not doing that with @robertodauria during
the review of m-lab/ndt7-client-go#39.
As part of such work, we also double checked that every TCPInfo
field described by the spec is a meaningful ndt7 summary.
As a result we can now close #194.
This change is