Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate token required flags for ndt5 and ndt7 #286

Merged
merged 2 commits into from
May 4, 2020

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented May 4, 2020

This change adds independent flags for requiring access tokens for the ndt5 and ndt7 servers.

This change will allow us to require access tokens on ndt7 before ndt5 in order to remediate some negative client scheduling behavior.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented May 4, 2020

Pull Request Test Coverage Report for Build 1274

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 79.642%

Files with Coverage Reduction New Missed Lines %
ndt7/upload/sender/sender.go 5 67.65%
Totals Coverage Status
Change from base Build 1265: -0.2%
Covered Lines: 1647
Relevant Lines: 2068

💛 - Coveralls

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)

@stephen-soltesz stephen-soltesz merged commit 7e1352c into master May 4, 2020
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-require-ndt7 branch May 4, 2020 16:22
@stephen-soltesz
Copy link
Contributor Author

@stephen-soltesz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants