Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "netx" package to replace fdcache #296

Merged
merged 7 commits into from
Jun 9, 2020

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jun 8, 2020

This change adds a new package (tentatively named "netx") that provides a fully managed set of types supporting the net.Listener, net.Conn, and net.Addr interfaces while fully encapsulating the operations needed to support BBR and TCP info operations for "raw", "http" and "https" servers (i.e. ndt5 and ndt7).

This change adds the package. But, due to the change size, it does not yet replace or remove the fdcache package, nor does this change remove the CachingTCPKeepAliveListener.

The changes outside the netx package are minor, changing the name and return type of GetBBRInfo to use primitive types and mirror GetTCPInfo.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Jun 8, 2020

Pull Request Test Coverage Report for Build 1340

  • 113 of 117 (96.58%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.8%) to 81.111%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ndt7/measurer/measurer.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 72.32%
ndt7/measurer/measurer.go 1 85.23%
ndt7/upload/sender/sender.go 3 74.29%
Totals Coverage Status
Change from base Build 1338: 0.8%
Covered Lines: 1752
Relevant Lines: 2160

💛 - Coveralls

@stephen-soltesz stephen-soltesz changed the title Add "magic" package to replace fdcache Add "netx" package to replace fdcache Jun 9, 2020
@stephen-soltesz
Copy link
Contributor Author

Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very very good to me.

This makes the code clearer and better and is just frigging great. Thank you for doing it.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pboothe)

@stephen-soltesz stephen-soltesz merged commit aa60c28 into master Jun 9, 2020
@stephen-soltesz stephen-soltesz deleted the soltesz-replace-fdcache branch June 9, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants