Create http.Server with Read and Write timeouts #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes #293 and adds similar preventative timeouts to the
ServeOnce
servers used by NDT5 plain, ws, and wss measurements.This change adds
ReadTimeout
andWriteTimeout
to thehttp.Server
used by the control channel for all NDT5 and NDT7 servers. The plain server control channel provides it's own timeout logic.However, for
singleserving
servers, this change now adds a context timeout in theplainServer.ServeOnce
logic and uses the samehttp.Server
timeouts as the control ports for ws and wss servers.Also fixes #122
For a summary of how
http.Server
timeouts apply to the connection lifetime, see:https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)