Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error log #308

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Update error log #308

merged 1 commit into from
Jul 1, 2020

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Jul 1, 2020

This change adds the error message to the log message when the JSON encoder fails to encode a result.

This is an strange situation because the result struct does not have complex types, so it's unclear what is causing it to fail. Part of #307


This change is Reviewable

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nkinkade)

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1409

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 81.448%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ndt5/ndt5.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
ndt7/closer/closer.go 3 70.0%
ndt7/upload/sender/sender.go 5 65.91%
Totals Coverage Status
Change from base Build 1406: -0.4%
Covered Lines: 1699
Relevant Lines: 2086

💛 - Coveralls

@stephen-soltesz stephen-soltesz merged commit 3630aaa into master Jul 1, 2020
@stephen-soltesz stephen-soltesz deleted the soltesz-logerr branch July 1, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants