Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bigquery ignore tag for ConnectionInfo #368

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

cristinaleonr
Copy link
Contributor

@cristinaleonr cristinaleonr commented Aug 8, 2022

This PR removes the bigquery:"-" tag from the ConnectionInfo field.

Because this optional field was to be ignored by BQ, it caused a fatal error in the Gardener in an instance where it was included in the json file and BQ did not recognize the field.

20220806:ndt/ndt7 Load {Location: "gs://etl-mlab-oti/ndt/ndt7/2022/08/06/20220806T040510.251033Z-ndt7-mlab2-gru02-ndt.tgz.json"; Message: "Error while reading data, error message: JSON parsing error in row starting at position 951624: No such field: raw.Download.ClientMeasurements.ConnectionInfo. File: gs://etl-mlab-oti/ndt/ndt7/2022/08/06/20220806T040510.251033Z-ndt7-mlab2-gru02-ndt.tgz.json"; Reason: "invalid"}

This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 81.504%

Files with Coverage Reduction New Missed Lines %
ndt7/upload/sender/sender.go 5 65.91%
Totals Coverage Status
Change from base Build 1579: -0.2%
Covered Lines: 1767
Relevant Lines: 2168

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description explaining why we have made this change; this write up may be helpful for future source archeology. Can be briefl.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor Author

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor

@cristinaleonr cristinaleonr merged commit 5c97136 into master Aug 8, 2022
@cristinaleonr cristinaleonr deleted the sandbox-cristinaleon-ConnectionInfo branch August 8, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants