Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Debug level logging #374

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Aug 24, 2022

The ndt-server generates debug level logging and this is operationally costly for log retention, collection and provides negligible benefit for production deployments.

Ultimately, this setting should be configurable. Until then, this change makes the default log level InfoLevel.


This change is Reviewable

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1611

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 81.361%

Files with Coverage Reduction New Missed Lines %
ndt5/ndt5.go 1 89.5%
ndt5/protocol/protocol.go 2 83.86%
ndt5/web100/web100_linux.go 2 94.44%
ndt5/c2s/c2s.go 3 72.32%
Totals Coverage Status
Change from base Build 1607: -0.2%
Covered Lines: 1794
Relevant Lines: 2205

💛 - Coveralls

@stephen-soltesz stephen-soltesz merged commit 8ef8a7d into main Aug 24, 2022
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-nodebug branch August 24, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants