Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /health endpoint for ndt-server #376

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

cristinaleonr
Copy link
Contributor

@cristinaleonr cristinaleonr commented Sep 20, 2022

This PR adds a new /health endpoint for ndt-server, which writes out a 200 status code if the server is healthy (i.e., not in lame duck) and an error code otherwise.

This will be queried by the Heartbeat Service and incorporated into the local health assessment for the instance.

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 20, 2022

Pull Request Test Coverage Report for Build 1633

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.03%) to 81.643%

Files with Coverage Reduction New Missed Lines %
ndt5/ndt5.go 1 89.5%
ndt5/protocol/protocol.go 2 83.86%
ndt5/web100/web100_linux.go 2 94.44%
ndt5/c2s/c2s.go 3 72.32%
Totals Coverage Status
Change from base Build 1623: 0.03%
Covered Lines: 1819
Relevant Lines: 2228

💛 - Coveralls

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants