Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -compress-results flag to optionally disable compressing results #383

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Mar 14, 2023

This change adds a new flag (preserving prior default behavior) to enable or disable compressing ndt7 result files.

After this change, the ndt-server can use -compress-results=false to disable gzip compressed result files, making them jostler/autoloader compatible.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1644

  • 25 of 28 (89.29%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 81.948%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ndt7/results/file.go 19 22 86.36%
Files with Coverage Reduction New Missed Lines %
ndt5/c2s/c2s.go 1 74.11%
Totals Coverage Status
Change from base Build 1641: 0.5%
Covered Lines: 1834
Relevant Lines: 2238

💛 - Coveralls

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 831f242 into main Mar 15, 2023
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-uncompressed branch March 15, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants