Improve README #36
Improve README #36
Conversation
|
Can someone from M-Lab and Ooni please review this before pulling? |
| Building the Ooni RPM | ||
| ---------------------- | ||
|
|
||
| With the recursive clone of `ooni-support` in a temporary that is *not* inside |
There was a problem hiding this comment.
Can the temporary directory be inside $HOME if it's a few layers deep, such as in $HOME/tmp/ooni-support ? Or must it be completely outside of $HOME as in /tmp/ooni-deploy-tmp/ooni-support?
There was a problem hiding this comment.
I might prefer for these instructions to give an explicit example, instead of just describing the general requirements, such as:
$ T=$(mktemp --directory)
$ cd $T
$ git clone --recursive 'https://github.com/m-lab-tools/ooni-support.git'
$ cd ooni-support...etc.
However, this suggestion is an enhancement, not a blocker.
There was a problem hiding this comment.
It must be completely outside of $HOME.
Good comments, I will make those changes if I get some extra time before this gets pulled.
|
This issue exists to track README.md errata: #39 |
|
This looks good. I will merge it as soon as @technosopher and I sit down and give it one final review. |
|
This is superseded by #58. |
No description provided.