Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete test coverage for query package #20

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Nov 19, 2019

This change restructures some logic in query package to complete test coverage there. This change moves the meat of using the bigquery package into the bqiface package. This part is not yet covered.


This change is Reviewable

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 56

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+16.7%) to 100.0%

Totals Coverage Status
Change from base Build 55: 16.7%
Covered Lines: 149
Relevant Lines: 149

💛 - Coveralls

@pboothe
Copy link
Contributor

pboothe commented Nov 19, 2019

Would things be implemented differently if you had known about https://github.com/googleapis/google-cloud-go-testing/tree/master/bigquery/bqiface ?

Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked in person.

I agree this change is an improvement, and that i makes things better than they used to be. We both agree that this is a temporary stop on the way to a better long-term solution that it not yet clear to either of us.

Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit adf84c8 into master Nov 19, 2019
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-bq-tests branch August 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants