Update main to use setup.File interfaces #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pboothe
reviewed
Nov 19, 2019
There was a problem hiding this comment.
Please use ioutil and its MakeTemp functions instead of putting an empty file under source control.
Reviewable status: 0 of 1 LGTMs obtained
stephen-soltesz
commented
Nov 19, 2019
pboothe
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 LGTMs obtained
cmd/bigquery_exporter/main_test.go, line 49 at r2 (raw file):
func Test_main(t *testing.T) {
Random blank line
stephen-soltesz
commented
Nov 19, 2019
There was a problem hiding this comment.
Reviewable status:
cmd/bigquery_exporter/main_test.go, line 49 at r2 (raw file):
Previously, pboothe (Peter Boothe) wrote…
Random blank line
Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates main to use the new setup.File interfaces and completes unit test coverage.
Note: this is a breaking change with respect to the original handling of flags. The flag package is changed from
github.com/spf13/pflagso that we can take advantage offlagx.ArgsFromEnvandflagx.StringArray. As well, the separate flags for metric '--type' and '--query' filename are combined as--guage-query. This change removes support for counter queries, but adds a TODO. Counters are a special use-case that make queries more expensive and might be suited to a different collector implementation.This change is