Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

".dirty" in firmware version does not appear reliably #1074

Closed
sbourdeauducq opened this issue Jun 19, 2018 · 1 comment
Closed

".dirty" in firmware version does not appear reliably #1074

sbourdeauducq opened this issue Jun 19, 2018 · 1 comment

Comments

@sbourdeauducq
Copy link
Member

The version string is cached by cargo and recomputed when the contents of .git changes. This leads to inconsistencies around .dirty, which depends on the whole repository contents and not only .git.

Can be reproduced by compiling the firmware from a pristine git tree, then making a modification to the source, and recompiling without deleting the previous compilation results.

@whitequark
Copy link
Contributor

Fixed. But this makes builds take 8 seconds regardless of whether they're fresh or not because of some issue with dependency tracking I never figured out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants