coredevice: use device endian for kernel and RPC #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging without much fanfare, as Zynq isn't widely deployed yet. Is the protocol documented somewhere? (I don't think so, but if it is, we should add a note about endianness.) |
| @@ -76,15 +76,17 @@ def __init__(self, dmgr, host, ref_period, ref_multiplier=8, target="or1k"): | |||
| self.ref_multiplier = ref_multiplier | |||
| if target == "or1k": | |||
| self.target_cls = OR1KTarget | |||
| endian = ">" | |||
There was a problem hiding this comment.
This is redundant. @pca006132 do this instead:
endian = {"e": "<", "E": ">"}[self.target_cls.data_layout[0]]
No, it is not. Keeping doc in sync with source is difficult... |
occheung
added a commit
that referenced
this pull request
Aug 24, 2021
Related: artiq-zynq: https://git.m-labs.hk/M-Labs/artiq-zynq/pulls/126 artiq: #1588
occheung
added a commit
that referenced
this pull request
Sep 10, 2021
Related: artiq-zynq: https://git.m-labs.hk/M-Labs/artiq-zynq/pulls/126 artiq: #1588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIQ Pull Request
Description of Changes
Use device endian for kernel and RPC protocol.
Note: This breaks the protocol for artiq-zynq, users must update the zynq firmware after this change.
This improves the performance of integer array transfer for zynq. For large integer array transfer, the throughput difference:
(I can't get stable result for small transfers from zeus, so comparing them would likely just be noise)
(updated after removing redundant allocation in firmware)
There is no visible effect for or1k as or1k uses big endian, and the bottlenect is the device side for transfer so little overhead in the host side did not reflect on the performance. This PR only affects kernel and RPC protocol, other protocols like coremgmt or analyzer would not be affected as they are not performance critical.
Improvement for or1k device to host integer array transfer is planned, and should be simple.
Related Issue
#1255 (comment)
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
Code Changes
flake8to check code style (follow PEP-8 style).flake8has issues with parsing Migen/gateware code, ignore as necessary.Git Logistics
git rebase --interactive). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.