Skip to content

Commit

Permalink
vxlan: fix check for migration of static entry
Browse files Browse the repository at this point in the history
The check introduced by:
	commit 26a41ae
	Author: stephen hemminger <stephen@networkplumber.org>
	Date:   Mon Jun 17 12:09:58 2013 -0700

	    vxlan: only migrate dynamic FDB entries

was not correct because it is checking flag about type of FDB
entry, rather than the state (dynamic versus static). The confusion
arises because vxlan is reusing values from bridge, and bridge is
reusing values from neighbour table, and easy to get lost in translation.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
shemminger authored and davem330 committed Jun 19, 2013
1 parent 4afe215 commit eb064c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/vxlan.c
Expand Up @@ -579,7 +579,7 @@ static bool vxlan_snoop(struct net_device *dev,
return false;

/* Don't migrate static entries, drop packets */
if (!(f->flags & NTF_SELF))
if (f->state & NUD_NOARP)
return true;

if (net_ratelimit())
Expand Down

0 comments on commit eb064c3

Please sign in to comment.