tftp.c (rx_callback): simplify expressions containing unnecessary casts

m-labs · Apr 16, 2013 · e0e447f · e0e447f
1 parent 36613c7
commit e0e447f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/software/bios/tftp.c b/software/bios/tftp.c
@@ -55,8 +55,8 @@ static void rx_callback(unsigned int src_ip, unsigned short src_port,
 
 	if(length < 4) return;
 	if(dst_port != PORT_IN) return;
-	opcode = ((unsigned short)(data[0]) << 8)|((unsigned short)(data[1]));
-	block = ((unsigned short)(data[2]) << 8)|((unsigned short)(data[3]));
+	opcode = data[0] << 8 | data[1];
+	block = data[2] << 8 | data[3];
 	if(block < 1) return;
 	if(opcode == TFTP_DATA) { /* Data */
 		length -= 4;