s6ddrphy: revert CAS LATENCY 3 (configurable CAS Latency was buggy)

milkymist/s6ddrphy/__init__.py

@@ -8,31 +8,41 @@
 #
 # Assert dfi_rddata_en in the same cycle as the read
 # command. The data will come back on dfi_rddata
-# CL + 2 cycles later, along with the assertion 
+# 5 cycles later, along with the assertion 
 # of dfi_rddata_valid.
 #
-# This PHY supports configurable CAS Latency.
+# This PHY only supports CAS Latency 3.
 # Read commands must be sent on phase RDPHASE.
 # Write commands must be sent on phase WRPHASE.
 #/
 
 # Todo:
 #	- use CSR for bitslip?
+#	- add configurable CAS Latency
+#	- automatically determines wrphase / rdphase / latencies according to phy_settings
 
 from migen.fhdl.std import *
 from migen.bus.dfi import *
 from migen.genlib.record import *
 
+def get_latencies(phy_settings):
+	read_latency=5
+	write_latency=0
+	return read_latency, write_latency
+
 class S6DDRPHY(Module):
 	def __init__(self, pads, phy_settings, bitslip):
 		if phy_settings.type not in ["DDR", "LPDDR", "DDR2"]:
 			raise NotImplementedError("S6DDRPHY only supports DDR, LPDDR and DDR2")
+		if phy_settings.cl != 3:
+			raise NotImplementedError("S6DDRPHY only supports CAS LATENCY 3 for now")
 
 		a = flen(pads.a)
 		ba = flen(pads.ba)
 		d = flen(pads.dq)
 		nphases = phy_settings.nphases
 		self.phy_settings = phy_settings
+		read_latency, write_latency = get_latencies(phy_settings)
 
 		self.dfi = Interface(a, ba, nphases*d, nphases)
 		self.clk4x_wr_strb = Signal()
@@ -57,7 +67,7 @@ def __init__(self, pads, phy_settings, bitslip):
 		#
 
 		# select active phase
-		#             sys_clk   ____----____----
+		#             sys_clk   ----____----____
 		#  phase_sel(nphases=1) 0       0
 		#  phase_sel(nphases=2) 0   1   0   1
 		#  phase_sel(nphases=4) 0 1 2 3 0 1 2 3
@@ -338,11 +348,11 @@ def __init__(self, pads, phy_settings, bitslip):
 
 		self.comb += drive_dqs.eq(r_dfi_wrdata_en[1])
 
-		rddata_sr = Signal(phy_settings.cl+2)
-		sd_sys += rddata_sr.eq(Cat(rddata_sr[1:phy_settings.cl+2], d_dfi[phy_settings.rdphase].rddata_en))
+		rddata_sr = Signal(read_latency)
+		sd_sys += rddata_sr.eq(Cat(rddata_sr[1:read_latency], d_dfi[phy_settings.rdphase].rddata_en))
 
 		for n, phase in enumerate(self.dfi.phases):
 			self.comb += [
 				phase.rddata.eq(d_dfi[n].rddata),
 				phase.rddata_valid.eq(rddata_sr[0]),
-			]
+			]

top.py

@@ -38,6 +38,7 @@ def ns(t, margin=True):
 	row_a=13,
 	col_a=10
 )
+sdram_phy_read_latency, sdram_phy_write_latency = s6ddrphy.get_latencies(sdram_phy)
 sdram_timing = lasmicon.TimingSettings(
 	tRP=ns(15),
 	tRCD=ns(15),
@@ -46,8 +47,8 @@ def ns(t, margin=True):
 	tREFI=ns(7800, False),
 	tRFC=ns(70),
 
-	read_latency=5,
-	write_latency=0,
+	read_latency=sdram_phy_read_latency+0,
+	write_latency=sdram_phy_write_latency+0,
 
 	req_queue_size=8,
 	read_time=32,