Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC/IIR max/min values #4

Closed
hartytp opened this issue May 1, 2018 · 1 comment
Closed

ADC/IIR max/min values #4

hartytp opened this issue May 1, 2018 · 1 comment

Comments

@hartytp
Copy link

hartytp commented May 1, 2018

We need a means of checking whether any servo channel/profile has railed, and also of logging the IIR input/outputs over time (e.g. to watch for head room slowly decreasing due to fibre coupling efficiency degrading over time or whatever).

The way I'd imagine doing this (comments welcome) is:

  • for each channel/profile, we store the max/min IIR input (ADC value) and output (DDS ASD). These should clear on read, so that each read gives the max/min value since the last read. These max/min values should only update when the servo is running (integrator active). I think we previously discussed having just a "railed" indicator, but on reflection, max/min values would be nicer.
  • one schedules an experiment to run every 10s of seconds to minutes, which reads the max/min value for each profile one cares about and broadcasts them.
  • a GUI/log can then pick these up and do something with them
@jordens
Copy link
Member

jordens commented May 1, 2018

Please remove this to artiq. This repo is just legacy code.and won't evolve.

@hartytp hartytp closed this as completed May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants