Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ChecksumCapabilities for a IPv4/IPv6 environment #213

Closed
dlrobertson opened this issue May 15, 2018 · 1 comment
Closed

Improve ChecksumCapabilities for a IPv4/IPv6 environment #213

dlrobertson opened this issue May 15, 2018 · 1 comment
Labels
good first issue

Comments

@dlrobertson
Copy link
Collaborator

dlrobertson commented May 15, 2018 •
edited

The ChecksumCapabilities struct currently contains the members udpv4 and tcpv4 that will be used for IPv6 packets as well as IPv4 packets. These members should be changed to udp and tcp if they should be used for both IPv6 and IPv4. If it is possible that we can only offload udp or tcp checksums for one IP version and not the other, the udpv6 and tcpv6 members should be added and the UdpRepr::parse and TcpRepr::parse functions should be updated accordingly.
@whitequark
Copy link
Contributor

Let's just rename those to udp and tcp. If some hardware supports checksums for IPv4 but not IPv6, the driver can just disable offload to both. I feel like simplicity is more important than supporting such crap in an optimal way.

@dlrobertson dlrobertson mentioned this issue May 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @dlrobertson