Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource exhaustion test #193

Closed

Conversation

podhrmic
Copy link
Contributor

This is an attempt to recreate a simple resource exhaustion test.
The intent is to test whether the received data are dropped once they are processed (i.e. the buffer should never be full unless a single packet is larger than the backing up buffer). Indeed, this test fails and I am not sure why.

The real-life test is to run server.rs and send UDP packets at port 6969 until the buffer is exhausted.

@astro
Copy link
Contributor

astro commented Apr 19, 2018

Thank you for reporting this issue. Great that I'm not the only one having this problem! It is solved by PR #187.

Please note that your test does not terminate when there is no more problem.

@podhrmic
Copy link
Contributor Author

podhrmic commented Apr 19, 2018

Thanks for fixing it. Do you want me to add some termination criteria to the test (assuming we want to keep it)? Plus I would need to fix the CI build.

@whitequark
Copy link
Contributor

So, the underlying cause is that PacketBuffer may use one entry in the metadata ring buffer for the padding, which causes buffer exhaustion when the actual metadata entry is inserted.

I confirm that #187 is the correct way to fix this.

@podhrmic
Copy link
Contributor Author

Fixed with 6e2da5e

@podhrmic podhrmic closed this Jun 22, 2018
@podhrmic podhrmic deleted the resource_exhaustion_test branch June 22, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants