Ignore unrecognized NDISC options (as per RFC 4861). #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
reviewed
May 14, 2018
src/wire/ndisc.rs
Outdated
| @@ -228,7 +228,7 @@ impl<'a> Repr<'a> { | |||
| let opt = NdiscOption::new_checked(packet.payload())?; | |||
| match opt.option_type() { | |||
| NdiscOptionType::SourceLinkLayerAddr => Some(opt.link_layer_addr()), | |||
| _ => { return Err(Error::Unrecognized); } | |||
| _ => {} | |||
There was a problem hiding this comment.
Very minor nit: we use () for the do-nothing case. r=me once this is fixed.
progval
force-pushed
the
ignore-unknown-ndisc-options
branch
from
04e3e68
to
ecedf6d
Compare
|
@m-labs-homu r+ |
|
📌 Commit ecedf6d has been approved by |
m-labs-homu
pushed a commit
that referenced
this pull request
May 14, 2018
Closes: #210 Approved by: whitequark
|
💔 Test failed - status-travis |
dlrobertson
reviewed
May 14, 2018
progval
force-pushed
the
ignore-unknown-ndisc-options
branch
from
ecedf6d
to
3398964
Compare
|
@m-labs-homu r+ |
|
📌 Commit 3398964 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.ietf.org/html/rfc4861#section-4