Rename new method on Packet types to new_checked
#254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m-labs-homu try |
|
💔 Test failed - status-travis |
|
@m-labs-homu retry |
|
💔 Test failed - status-travis |
|
@m-labs-homu retry |
|
☀️ Test successful - status-travis |
|
Looks good! I like how explicit |
|
@m-labs-homu r=dlrobertson |
|
📌 Commit 4be0c8b has been approved by |
|
@m-labs-homu r- |
|
@m-labs-homu r=dlrobertson |
|
📌 Commit 23acdf5 has been approved by |
|
💔 Test failed - status-travis |
|
@m-labs-homu retry |
|
@m-labs-homu r=dlrobertson |
|
📌 Commit 9cb7e18 has been approved by |
|
💔 Test failed - status-travis |
|
@m-labs-homu r=dlrobertson |
|
📌 Commit 680f675 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195.
r? @dlrobertson, did I miss anything?