Provide Circuitpython compatibility by removing warning module #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I have never used CircuitPython or MicroPython myself, so I'm not sure what else would be needed (if anything) to successfully use this project on those platforms. This can be tracked in #64 (if you have any more insight into this, please feel free to make a comment there). But I agree that this warning is not completely necessary, and if it makes this library more compatible I think it's a good idea to remove it. |
m-lundberg
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
warningmodule is only used once in this library, and isn't needed at all IMHO. Removing it makes this library compatible with CircuitPython.