docs: replace references with source and some minor lints

DESCRIPTION

@@ -1,5 +1,5 @@
 Package: worldbank
-Title: Modern World Bank API Wrapper
+Title: Client for the World Bank API
 Version: 0.0.1
 Authors@R:
     person("Maximilian", "Muecke", , "muecke.maximilian@gmail.com", role = c("aut", "cre"),

R/api.R

@@ -7,7 +7,7 @@
 #'   \item{code}{The language code.}
 #'   \item{name}{The language name.}
 #'   \item{native_form}{The native form of the language name.}
-#' @references <http://api.worldbank.org/v2/languages>
+#' @source <http://api.worldbank.org/v2/languages>
 #' @export
 #' @examples
 #' wb_language()
@@ -33,12 +33,12 @@ wb_language <- function() {
 #'   \item{id}{The lending type ID.}
 #'   \item{iso2code}{The ISO 2 code of the lending type.}
 #'   \item{value}{The lending type value.}
-#' @references <http://api.worldbank.org/v2/lendingTypes>
+#' @source <http://api.worldbank.org/v2/lendingTypes>
 #' @export
 #' @examples
 #' wb_lending_type()
 wb_lending_type <- function(type = NULL, lang = "en") {
-  stopifnot(is_character_or_null(type), all(nchar(type) == 3L))
+  stopifnot(is_character_or_null(type), nchar(type) == 3L)
   type <- format_param(type)
 
   resource <- sprintf("lendingType/%s", type)
@@ -63,12 +63,12 @@ wb_lending_type <- function(type = NULL, lang = "en") {
 #'   \item{id}{The income level ID.}
 #'   \item{iso2code}{The ISO 2 code of the income level.}
 #'   \item{value}{The income level value.}
-#' @references <http://api.worldbank.org/v2/incomeLevels>
+#' @source <http://api.worldbank.org/v2/incomeLevels>
 #' @export
 #' @examples
 #' wb_income_level()
 wb_income_level <- function(income = NULL, lang = "en") {
-  stopifnot(is_character_or_null(income), all(nchar(income) == 3L))
+  stopifnot(is_character_or_null(income), nchar(income) == 3L)
   income <- format_param(income)
 
   resource <- sprintf("incomeLevel/%s", income)
@@ -99,7 +99,7 @@ wb_income_level <- function(income = NULL, lang = "en") {
 #'   \item{data_availability}{Whether the source has data available.}
 #'   \item{metadata_availability}{Whether the source has metadata available.}
 #'   \item{concepts}{The concepts associated with the source.}
-#' @references <http://api.worldbank.org/v2/sources>
+#' @source <http://api.worldbank.org/v2/sources>
 #' @export
 #' @examples
 #' wb_source()
@@ -136,7 +136,7 @@ wb_source <- function(source = NULL, lang = "en") {
 #'   \item{id}{The topic ID.}
 #'   \item{value}{The topic value.}
 #'   \item{source_note}{The source note.}
-#' @references <http://api.worldbank.org/v2/topics>
+#' @source <http://api.worldbank.org/v2/topics>
 #' @export
 #' @examples
 #' wb_topic()
@@ -167,7 +167,7 @@ wb_topic <- function(topic = NULL, lang = "en") {
 #'   \item{code}{The region code.}
 #'   \item{iso2code}{The ISO 2 code of the region.}
 #'   \item{name}{The region name.}
-#' @references <http://api.worldbank.org/v2/region>
+#' @source <http://api.worldbank.org/v2/region>
 #' @export
 #' @examples
 #' wb_region()
@@ -216,13 +216,13 @@ wb_region <- function(region = NULL, lang = "en") {
 #'   \item{capital_city}{The capital city.}
 #'   \item{longitude}{The longitude.}
 #'   \item{latitude}{The latitude.}
-#' @references <http://api.worldbank.org/v2/country>
+#' @source <http://api.worldbank.org/v2/country>
 #' @export
 #' @examples
 #' wb_country()
 wb_country <- function(country = NULL, lang = "en") {
   stopifnot(
-    is_character_or_null(country), all(nchar(country) %in% 2:3),
+    is_character_or_null(country), nchar(country) %in% 2:3,
     is_string(lang), nchar(lang) == 2L
   )
   country <- tolower(format_param(country))
@@ -276,7 +276,7 @@ wb_country <- function(country = NULL, lang = "en") {
 #'   \item{source_organization}{The source organization.}
 #'   \item{topic_id}{The topic ID.}
 #'   \item{topic_value}{The topic value.}
-#' @references <http://api.worldbank.org/v2/indicator>
+#' @source <http://api.worldbank.org/v2/indicator>
 #' @export
 #' @examples
 #' wb_indicator("NY.GDP.MKTP.CD")
@@ -336,7 +336,7 @@ wb_indicator <- function(indicator = NULL, lang = "en") {
 #'   \item{unit}{The indicator unit.}
 #'   \item{obs_status}{The observation status.}
 #'   \item{decimal}{The decimal.}
-#' @references <http://api.worldbank.org/v2/country/{country}/indicator/{indicator}>
+#' @source <http://api.worldbank.org/v2/country/{country}/indicator/{indicator}>
 #' @export
 #' @examples
 #' wb_country_indicator("NY.GDP.MKTP.CD", "US")
@@ -347,7 +347,7 @@ wb_country_indicator <- function(indicator = "NY.GDP.MKTP.CD",
                                  end_year = NULL) {
   stopifnot(
     is_string(indicator),
-    is_character_or_null(country), all(nchar(country) %in% 2:3)
+    is_character_or_null(country), nchar(country) %in% 2:3
   )
   has_start_year <- !is.null(start_year)
   has_end_year <- !is.null(end_year)

R/utils.R

@@ -15,11 +15,11 @@ as_tibble <- function(x) {
 }
 
 na_if_empty <- function(x) {
-  replace(x, x == "", NA_character_)
+  replace(x, !nzchar(x), NA_character_)
 }
 
 to_logical <- function(x) {
-  ifelse(x == "Y", TRUE, FALSE)
+  x == "Y"
 }
 
 map <- function(.x, .f, ...) {

tests/testthat/test-wb.R

@@ -1,6 +1,6 @@
 test_that("wb_lending_type input validation works", {
   # type should be a three letter code or NULL
-  expect_error(wb_lending_type(character(0)))
+  expect_error(wb_lending_type(character()))
   expect_error(wb_lending_type(""))
   expect_error(wb_lending_type("ab"))
   expect_error(wb_lending_type("abcd"))
@@ -18,7 +18,7 @@ test_that("wb_lending_type input validation works", {
 
 test_that("wb_income_level input validation works", {
   # income should be a three letter code or NULL
-  expect_error(wb_income_level(character(0)))
+  expect_error(wb_income_level(character()))
   expect_error(wb_income_level(""))
   expect_error(wb_income_level("ab"))
   expect_error(wb_income_level("abcd"))
@@ -36,7 +36,7 @@ test_that("wb_income_level input validation works", {
 
 test_that("wb_source input validation works", {
   # source should be a character vector or NULL
-  expect_error(wb_source(character(0)))
+  expect_error(wb_source(character()))
   expect_error(wb_source(NA))
   expect_error(wb_source(1L))
   expect_error(wb_source(TRUE))
@@ -50,7 +50,7 @@ test_that("wb_source input validation works", {
 
 test_that("wb_topic input validation works", {
   # topic should be a character vector or NULL
-  expect_error(wb_topic(character(0)))
+  expect_error(wb_topic(character()))
   expect_error(wb_topic(NA))
   expect_error(wb_topic(1L))
   expect_error(wb_topic(TRUE))
@@ -64,7 +64,7 @@ test_that("wb_topic input validation works", {
 
 test_that("wb_region input validation works", {
   # region should be a character vector or NULL
-  expect_error(wb_region(character(0)))
+  expect_error(wb_region(character()))
   expect_error(wb_region(NA))
   expect_error(wb_region(1L))
   expect_error(wb_region(TRUE))
@@ -81,7 +81,7 @@ test_that("wb_country input validation works", {
   expect_error(wb_country("a"))
   expect_error(wb_country("abcd"))
   expect_error(wb_country(c("ab", "abcd")))
-  expect_error(wb_country(character(0)))
+  expect_error(wb_country(character()))
   expect_error(wb_country(NA))
   expect_error(wb_country(1L))
   expect_error(wb_country(TRUE))
@@ -98,7 +98,7 @@ test_that("wb_indicator input validation works", {
   expect_error(wb_indicator("a"))
   expect_error(wb_indicator("abcd"))
   expect_error(wb_indicator(c("ab", "abcd")))
-  expect_error(wb_indicator(character(0)))
+  expect_error(wb_indicator(character()))
   expect_error(wb_indicator(NA))
   expect_error(wb_indicator(1L))
   expect_error(wb_indicator(TRUE))
@@ -120,7 +120,7 @@ test_that("wb_country_indicator input validation works", {
   expect_error(wb_country_indicator(country = "a"))
   expect_error(wb_country_indicator(country = "abcd"))
   expect_error(wb_country_indicator(country = c("ab", "abcd")))
-  expect_error(wb_country_indicator(country = character(0)))
+  expect_error(wb_country_indicator(country = character()))
   expect_error(wb_country_indicator(country = NA))
   expect_error(wb_country_indicator(country = 1L))
   expect_error(wb_country_indicator(country = TRUE))