Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrae.fit() training loop needs early stopping mechanism #1

Closed
m-nolan opened this issue May 13, 2022 · 0 comments
Closed

mrae.fit() training loop needs early stopping mechanism #1

m-nolan opened this issue May 13, 2022 · 0 comments

Comments

@m-nolan
Copy link
Owner

m-nolan commented May 13, 2022

for epoch_idx in tqdm(range(max_epochs)):

The current training loop runs and optimizes the model to minimize training loss. This has no stop point beyond the max iterations argument.

This needs an early stopping mechanism, either a moving average of the loss delta, some train/valid loss crossover, etc.

Test with the sample dataset.
Add a test with random data (?) to show that it works to stop training if it isn't learning anything.

@m-nolan m-nolan closed this as completed May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant