Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include src/parser.c file in the repository #72

Open
Eli-Zaretskii opened this issue Mar 4, 2023 · 0 comments
Open

Please include src/parser.c file in the repository #72

Eli-Zaretskii opened this issue Mar 4, 2023 · 0 comments

Comments

@Eli-Zaretskii
Copy link

Commit 98d9b300c0, with the log message Merge branch 'improve-from-clause', removed the file src/parser.c from the repository. This causes the command treesit-install-language-grammar available in Emacs 29 and later to fail to produce and install the tree-sitter grammar library for SQL. See the Emacs bug report for more details.

Emacs 29 provides this command for those Emacs users who are not proficient in building libraries and don't necessarily have the development tools, such as those required to generate the parser.c file, available. All the other tree-sitter grammar libraries supported by Emacs do provide the parser's C or C++ source file in the repository. Requiring those users to install the necessary tools could in practice mean some of them will be unable to produce the grammar library when they need it.

Would it be possible for you to include src/parser.c file in the repository, as it was there before the above commit?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant