Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLB Animation Input Different Fix Parsing #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danieljiwonkang98
Copy link

Below was the input for the parsing animation, but since each word did not have quotation it was not parsing correctly, the code fix fixes this issue
String input = '''
(
Attack,
Bounce,
Clicked,
Death,
Eat,
Fear,
Fly,
Hit,
"Idle_A",
"Idle_B",
"Idle_C",
Jump,
Roll,
Run,
Sit,
Spin,
Swim,
Walk
)
''';

@danieljiwonkang98
Copy link
Author

@m-r-davari Can you check this? The current package has issue when parsing animation list that is listed like below (since double quotation is not included in all animation words it causes parsing issue)

String input = '''
(
Attack,
Bounce,
Clicked,
Death,
Eat,
Fear,
Fly,
Hit,
"Idle_A",
"Idle_B",
"Idle_C",
Jump,
Roll,
Run,
Sit,
Spin,
Swim,
Walk
)
''';

@m-r-davari
Copy link
Owner

Thanks for your PR,
It is not very regular that some animation name contains "" and some don't, but code improvement to support this kind of models is helpful.
The method "_tupleToList" is necessary for loading some model in iOS, you must edit your pr to make sure both your logic and previous will work together. and check it on Android, iOS and Web platform.
also please include your model to PR in package example that I could check it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants