Skip to content

Commit

Permalink
remove type for response
Browse files Browse the repository at this point in the history
  • Loading branch information
Naoray committed Jun 5, 2019
1 parent b874958 commit f840eb0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .phpunit.result.cache
@@ -1 +1 @@
C:37:"PHPUnit\Runner\DefaultTestResultCache":2452:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:22:{s:106:"Mshule\LaravelPipes\Tests\PipeRequestTest::a_not_found_pipe_exception_is_thrown_if_no_controller_was_found";d:0.119;s:73:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_returns_a_ok_200er_response";d:0.03;s:100:"Mshule\LaravelPipes\Tests\PipeRequestTest::the_response_can_be_changed_through_the_response_resolver";d:0.017;s:122:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_request_event_when_a_request_is_handled_by_the_kernel";d:0.017;s:125:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_response_event_when_a_response_is_returned_by_the_kernel";d:0.017;s:76:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_callbacks";d:0.018;s:77:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_matches_everything_to_lowercase";d:0.018;s:85:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions";d:0.019;s:114:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions_through_using_the_fluent_api";d:0.018;s:80:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_with_middlewares";d:0.021;s:111:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_grouped_pipes_and_pass_all_key_to_the_contained_pipes";d:0.02;s:127:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_fallback_pipes_to_handle_any_request_which_could_not_be_matched_otherwise";d:0.019;s:74:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters";d:0.019;s:140:"Mshule\LaravelPipes\Tests\PipeRequestTest::its_dynamic_pattern_match_checks_first_for_placeholder_name_in_request_then_for_default_cue_value";d:0.014;s:83:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_multiple_dynamic_parameters";d:0.023;s:89:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters_to_any_request";d:0.02;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_conditions_to_pipe_definitions";d:0.029;s:70:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_to_pipes";d:0.018;s:81:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_predefined_to_pipes";d:0.019;s:78:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_bind_models_to_pipe_requests";d:0.029;s:71:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_load_pipes_from_files";d:0.019;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_ignores_global_helper_functions_as_cue";d:0.021;}}}
C:37:"PHPUnit\Runner\DefaultTestResultCache":2453:{a:2:{s:7:"defects";a:0:{}s:5:"times";a:22:{s:106:"Mshule\LaravelPipes\Tests\PipeRequestTest::a_not_found_pipe_exception_is_thrown_if_no_controller_was_found";d:0.531;s:73:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_returns_a_ok_200er_response";d:0.052;s:100:"Mshule\LaravelPipes\Tests\PipeRequestTest::the_response_can_be_changed_through_the_response_resolver";d:0.021;s:122:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_request_event_when_a_request_is_handled_by_the_kernel";d:0.021;s:125:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_fires_an_incoming_pipe_response_event_when_a_response_is_returned_by_the_kernel";d:0.019;s:76:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_callbacks";d:0.02;s:77:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_matches_everything_to_lowercase";d:0.018;s:85:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions";d:0.027;s:114:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_to_controller_actions_through_using_the_fluent_api";d:0.019;s:80:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_pipes_with_middlewares";d:0.021;s:111:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_resolve_grouped_pipes_and_pass_all_key_to_the_contained_pipes";d:0.022;s:127:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_fallback_pipes_to_handle_any_request_which_could_not_be_matched_otherwise";d:0.021;s:74:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters";d:0.019;s:140:"Mshule\LaravelPipes\Tests\PipeRequestTest::its_dynamic_pattern_match_checks_first_for_placeholder_name_in_request_then_for_default_cue_value";d:0.023;s:83:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_multiple_dynamic_parameters";d:0.021;s:89:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_match_dynamic_parameters_to_any_request";d:0.019;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_conditions_to_pipe_definitions";d:0.031;s:70:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_to_pipes";d:0.017;s:81:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_add_aliases_predefined_to_pipes";d:0.02;s:78:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_bind_models_to_pipe_requests";d:0.032;s:71:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_can_load_pipes_from_files";d:0.025;s:84:"Mshule\LaravelPipes\Tests\PipeRequestTest::it_ignores_global_helper_functions_as_cue";d:0.021;}}}
4 changes: 2 additions & 2 deletions src/Response.php
Expand Up @@ -2,7 +2,6 @@

namespace Mshule\LaravelPipes;

use Illuminate\Http\Response as HttpResponse;
use Illuminate\Foundation\Testing\TestResponse;

class Response
Expand All @@ -11,9 +10,10 @@ class Response
* Creates a test response if the app is in testing environment.
*
* @param HttpResponse $response
*
* @return \Illuminate\Http\Response|\Illuminate\Foundation\Testing\TestResponse
*/
public static function from(HttpResponse $response)
public static function from($response)
{
return app()->environment('testing')
? new TestResponse($response)
Expand Down

0 comments on commit f840eb0

Please sign in to comment.