Wrap socket type with a class instead of a function. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By wrapping the `socket.socket` type with a function, we've been emulating only the wrapped type's constructor and not the wrapped type itself. This won't work if we wish to enable long polling for SOCKS connections with the SocksiPy library as this library imports and attempts to construct a class that inherits from the `socket.socket` type. Original wrapper function was added in 6cf0bc7, but the issue this commit attempts to address was triggered by a change in module import order in a5ab744, where SocksiPy wraps poclbm's own socket wrapper, where before it had been wrapping the system-provided socket type. This commit addresses m0mchil/poclbm#56. If we don't need long polling on SOCKS, live-mining/poclbm@ce05212c53a30386da94a5aebd1d581d5421a354 is also a fix for the immediate issue.
m0mchil
added a commit
that referenced
this pull request
Apr 1, 2013
…-socket-type Wrap socket type with a class instead of a function.
|
Thanks, that is what I intended too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By wrapping the
socket.sockettype with a function, we've been emulating only the wrapped type's constructor and not the wrapped type itself. This won't work if we wish to enable long polling for SOCKS connections with the SocksiPy library as this library imports and attempts to construct a class that inherits from thesocket.sockettype.Original wrapper function was added in 6cf0bc7, but the issue this pull request attempts to address was triggered by a change in module import order in a5ab744, where SocksiPy wraps poclbm's own socket wrapper, where before it had been wrapping the system-provided socket type. This pull request addresses #56. If we don't need long polling on SOCKS, live-mining/poclbm@ce05212c53a30386da94a5aebd1d581d5421a354 is also a fix for the immediate issue described in issue 56.