Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal recommendations #220

Merged
merged 5 commits into from
Sep 3, 2017
Merged

Conversation

jingai
Copy link
Collaborator

@jingai jingai commented Sep 1, 2017

Remove script.skin.helper.widgets dependency and provide a similar implementation.

The biggest difference is that this doesn't filter on rating, but instead sorts on it, limits the number of items, and picks a random item from that. The benefit of doing it this way is that we always have something to recommend.

It is also much faster since we're not pinging an addon for the info.

Additionally, this adds support for filtering recommendations on a supplied Genre.

Requires changes to Kodi-Voice provided by m0ngr31/kodi-voice#19

Addresses Issue #193.

@mcl22
Copy link

mcl22 commented Sep 2, 2017

Here we go:
RecommendMovie welchen (/{MovieGenre}) Film es (/mir) (empfiehlt/vorschlägt)
RecommendShow welche (/{ShowGenre}) Serie es (/mir) (empfiehlt/vorschlägt)
RecommendEpisode welche (/{ShowGenre}) (Folge/Episode) es (/mir) (empfiehlt/vorschlägt)
RecommendMusicVideo welches (/{MusicVideoGenre}) Musikvideo es (/mir) (empfiehlt/vorschlägt)
RecommendArtist welchen (/{MusicGenre}) Interpreten es (/mir) (empfiehlt/vorschlägt)
RecommendAlbum welches (/{MusicGenre}) Album es (/mir) (empfiehlt/vorschlägt)
RecommendSong (welches (/{MusicGenre}) Lied/welchen (/{MusicGenre}) Song) es (/mir) (empfiehlt/vorschlägt)

@jingai
Copy link
Collaborator Author

jingai commented Sep 3, 2017

Thanks @mcl22 !

@jingai jingai merged commit c6c5308 into m0ngr31:master Sep 3, 2017
@jingai jingai deleted the internal-recommendations branch September 3, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants