Use pkgconfig-depends for fuse dependency #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a compilation problem on OS X, since here at least the fuse library is known as osxfuse instead of fuse. Should work reliably on other platforms as well thanks to the cross-platform nature of pkg-config. Also remove fuse.h from global includes list; this was causing compilation failure on OS X due to not having a FUSE_USE_VERSION defined previously.
|
First of all, Thank you very much. This is absolutely not dumb. However, since I took over this package and it does not and has not used pkgconfig this is a relatively major change. Something, if we decided to go this direction would need a significant version bump. Can we get a pull to make it work without pkgconfig |
|
I would hate to use pkgconfig now, since the package has been out for so long. If this is a need, we can explore adding pkgconfig as a minor update. I would prefer for the software to work without it, or for cabal to look for pkgconfig and then install the old way if pkgconfig is not available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes build failure on OS X; details in the commit comment.
I'm pretty new to Haskell so there's a decent chance I'm doing something dumb with this, but the Cabal docs say pkgconfig-depends is preferable so I ran with it.
I'm a little nervous about the impact of this on other platforms (Linux, FreeBSD, OS X with MacFUSE instead of OSXFUSE), since I haven't tested these. In theory, all of those should have their FUSE registered with pkg-config, so it should be fine... but testing this on another machine or two would probably be a good idea.