Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismissing a view displaying over view presented with MZFormSheetPresentationController reveals missing parent. #20

Closed
ay8s opened this issue Aug 31, 2015 · 6 comments

Comments

@ay8s
Copy link
Contributor

ay8s commented Aug 31, 2015

Hey @m1entus.

Not sure if you've seen this one before but also seeing it when presenting another view using MZFormSheetPresentationController.

When presenting the new view the presenting view animates out but doesn't seem to come back when dismissing the child modal.

Video: http://cl.ly/051F0Q2m3e3V

Dug into this a little but couldn't find the route cause of it.

@ay8s
Copy link
Contributor Author

ay8s commented Aug 31, 2015

For MZFormSheetPresentationTransitionStyleSlideFromBottom it looks like the originalFormSheetRect gets set to the dismissed frame and so the modal doesn't get animated back in as the frame remains offscreen.

@ay8s
Copy link
Contributor Author

ay8s commented Aug 31, 2015

Not sure how best to handle this case, I've currently duplicated the slide transition and added a call to setupFormSheetViewControllerFrame, which corrects the frame before the animation back in. I'm sure there's a better solution though.

@m1entus
Copy link
Owner

m1entus commented Aug 31, 2015

Not sure about it, actually i am little bit busy, when i will find some free time and motivation i will review issues and try to fix it :) Anyway thanks for reporting!

@nitinhayaran
Copy link

+1

m1entus added a commit that referenced this issue Oct 17, 2015
…sented with MZFormSheetPresentationController reveals missing parent.
@m1entus
Copy link
Owner

m1entus commented Oct 17, 2015

I made temporary fix to it, but in future i will have to change it.

@m1entus m1entus closed this as completed Oct 17, 2015
@m1entus
Copy link
Owner

m1entus commented Oct 18, 2015

Fully fixed in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants