Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffprobe cache #26

Open
rudnypc opened this issue Dec 3, 2021 · 9 comments
Open

ffprobe cache #26

rudnypc opened this issue Dec 3, 2021 · 9 comments
Labels
bug Something isn't working

Comments

@rudnypc
Copy link

rudnypc commented Dec 3, 2021

When the cache is true, can we save the ffprobe stream result? Every request to the same file with different resolution (maybe the same too), the ffprobe is running again.

@m1k1o
Copy link
Owner

m1k1o commented Dec 3, 2021

Hmm, it should not do again. Is the cache file there?

@m1k1o
Copy link
Owner

m1k1o commented Dec 3, 2021

I tried it, got media local cache hit and no ffprobe running. Do you use global or local cache? Do you see this entry in log?

@rudnypc
Copy link
Author

rudnypc commented Dec 3, 2021

I'm using cache inside the vod tag, Should I put this cache outsite?

@m1k1o
Copy link
Owner

m1k1o commented Dec 3, 2021

I'm using cache inside the vod tag,

Correct.

Found some issue, when cache does not contain keyframes (if selected) when accesssing master playlist.

@rudnypc
Copy link
Author

rudnypc commented Dec 6, 2021

The ffprobe now is starting from the master and each profile. Before ffprobe was only started from the profile.

@m1k1o
Copy link
Owner

m1k1o commented Dec 6, 2021

They should share the same cache. But I think, the problem is race condition. When master profile starts ffprobe, it takes some time. If some profile starts in meanwhile, it does not see cache entry and starts again. It does not know, that other ffprobe is in progress, since every profile has its own manager started.

@rudnypc
Copy link
Author

rudnypc commented Dec 6, 2021

sorry, now that I made a mistake, the cache is working now

@rudnypc
Copy link
Author

rudnypc commented Dec 6, 2021

Ok, but when I set the cache is true, the generator doesn't use the ffprobe keyframe

@m1k1o
Copy link
Owner

m1k1o commented Dec 6, 2021

Another problem is, that when the cache exists, even without keyframes, it does not generate them. I think that should be fixed too. So if you have valid cache without keyframes, it won't generate them additionally.

@m1k1o m1k1o added the bug Something isn't working label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants