removes small lags from video live streamings #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1k1o
reviewed
Mar 1, 2021
m1k1o
reviewed
Mar 1, 2021
|
Thank you for your contibution, I will run some tests on it and see how it performs for me. |
m1k1o
added a commit
that referenced
this pull request
Jun 23, 2024
* xserver dummy with RandR. * update. * remove screen configurations from xorg. * screen size cannot be nil anymore. * use predefined screen configurations. * use screen configurations. * fix error. * remove comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the reason for the small lags was a buffering problem of the encoder.
With this PR I no lags at all (tested on a i7-2600k)
Further I readded the rtcp listener, since in the new pion examples they are still implemented and seem to be necessary for the functionality ( https://github.com/pion/webrtc/blob/33d953e1eb58bb308128b011677cf60f5e1d261b/examples/reflect/main.go#L34 // https://github.com/pion/webrtc/blob/33d953e1eb58bb308128b011677cf60f5e1d261b/examples/reflect/main.go#L73 )