Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reconnect after WebSocket Timeout(server restart) #268

Closed
wants to merge 1 commit into from
Closed

add reconnect after WebSocket Timeout(server restart) #268

wants to merge 1 commit into from

Conversation

urbanekpj
Copy link

@urbanekpj urbanekpj commented Mar 28, 2023

and

i try use auto login via url params. but if server is restarted then auto connect/reconnect/retry no working.
as far as i check code retry is more focused on webrtc connection not on webscoket?

on PR some changes to add reconnect when ws raport timeout.
but i'm not sure what was original logic in connect.vue ( members was not set in onMounted?).

also not sure if

if (reason?.message == 'connection timeout') {

is correct way to check Error.
also maybe cancel button should be added if connection is true?

…thru data channel is connection is not opened
@m1k1o
Copy link
Owner

m1k1o commented Mar 30, 2023

Yes, we do not have currently proper websocket reconnection logic. And even whole neko session is bound to living websocket connection.

We should add some kind of reconnect function, that will perform websocket reconnection without any arguments. Because now we need to know username & password.

And also I would say, that reconnection should be happening when we discover that we are not connected and should be. Not only connection timeout.

@urbanekpj urbanekpj closed this by deleting the head repository Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants