Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Translation of strings and help v1 #490

Merged
merged 1 commit into from Dec 8, 2018
Merged

Conversation

BlackLotus64
Copy link
Contributor

A call to Spanish reviewers to check terminology and context :)

@m2049r
Copy link
Owner

m2049r commented Nov 26, 2018

@erciccione ^^

@erciccione
Copy link
Contributor

Sorry i totally missed this. Maybe @lh1008 could help

Copy link

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good translation. Just suggested some minor changes.

Thank you guys for your work.

@erciccione :)

app/src/main/res/values-es/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-es/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-es/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-es/help.xml Show resolved Hide resolved
@BlackLotus64
Copy link
Contributor Author

Changes made after the review, waiting for an approve @lh1008 and it will be ready to merge :)

Copy link

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Thank you @BlackLotus64

Reviewed @erciccione :)

@m2049r m2049r merged commit e9313bc into m2049r:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants