Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated pt-BR translation help and node strings #491

Merged
merged 4 commits into from Jan 5, 2019

Conversation

netrik182
Copy link
Contributor

No description provided.

@m2049r
Copy link
Owner

m2049r commented Dec 15, 2018

@vp1111 do you have a new ETA for the review?

@bitlamas
Copy link
Contributor

My business trip got extended until this Tuesday. Wednesday I will be home so I should be able to properly do it before the next weekend if that's alright.

Copy link
Contributor

@bitlamas bitlamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the reviews are not grammar mistakes, but suggestions on how to improve the translation from a "literal translation" to a more contextualized, adapted version.

app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/help.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-pt-rBR/strings.xml Outdated Show resolved Hide resolved
@netrik182
Copy link
Contributor Author

thanks @vp1111 for the review. Files were updated.

@m2049r m2049r merged commit 5ee5a81 into m2049r:master Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants