Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukranian translation for Monerujo #517

Merged
merged 10 commits into from Jan 12, 2019
Merged

Ukranian translation for Monerujo #517

merged 10 commits into from Jan 12, 2019

Conversation

TheFuzzStone
Copy link
Contributor

Ping to review: @LvMsterfild @v1docq47

@TheFuzzStone
Copy link
Contributor Author

@v1docq47, fixed a few typos in Russian translation. Can you check it? Thanks!

Copy link
Owner

@m2049r m2049r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to escape apostrophes (as \' or ') like in "ім'я гаманця".

Click on the "Detail" link under "All checks have failed" to see possible other errors in the black window.

@TheFuzzStone
Copy link
Contributor Author

@m2049r, now we have "All checks have passed", so all is ok?
Sorry, I'm a noob with GIT :-/

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @TheFuzzStone, now it's fine. Happy to see this finally completed. Thank you.
Next time, please open another PR for changes to another language.

Task on Taiga: https://taiga.getmonero.org/project/erciccione-monero-localization/task/251

@v1docq47
Copy link
Contributor

v1docq47 commented Jan 12, 2019 via email

@m2049r
Copy link
Owner

m2049r commented Jan 12, 2019

@TheFuzzStone perfect 👍

@m2049r m2049r merged commit 909ff8c into m2049r:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants