Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global switch for "exclude files outside source directories" #109

Open
ctron opened this issue Jul 10, 2017 · 2 comments
Open

Global switch for "exclude files outside source directories" #109

ctron opened this issue Jul 10, 2017 · 2 comments

Comments

@ctron
Copy link

ctron commented Jul 10, 2017

Assume you have a checkstyle configuration as described in [1], also checking pom.xml files in the root directory of the project, then currently those errors (on the module root) will not be shown by checkstyle in Eclipse, but reported by checkstyle run from Maven.

It is possible to open the project local settings for checkstyle and select the java-sources-checkstyle-check resource set and untick "files outside source directories". However this has to be done on each and every desktop for each and every project.

[1] https://vzurczak.wordpress.com/2016/11/28/checking-root-resources-with-checkstyle-and-maven/

@ctron
Copy link
Author

ctron commented Jul 10, 2017

My suggestion would be to untick this flag by default and simply use the source set provided by the checkstyle plugin configuration from maven.

@vorburger
Copy link
Member

@ctron hallo Jens, nice to "see" you again here too... I know (from knowing you) that you know how this opensource thing 😃 works - as per #124 I wouldn't have the time to look into and fix this issue, but if you could raise a PR which fixes, I can (now) promise that we can get it merged and released (#123) ... looking forward to your contributions! 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants