Paragraph-Style for Bullet-Point-Lists not working

[georgbachmann]

I seems that it's not properly respecting lineSpacings of Bullet-Point-Lists?!?

We are using non-default lineSpacings and noticed that the lists aren't quite the same. So I dug a bit into the code and noticed in ListAttributedStringLayoutBlockBuilder.swift in function getBulletIndentingAttributesForLevel when creating the paragraphStyle the lineSpacing isn't set. I fixed it by adding the line

paragraphStyle.lineSpacing = listStyling?.neededLineHeight() ?? 0

and now it's working as expected.

I guess it's a bug in marky-mark?!?
Also... shouldn't lineHeight in LineHeightStylingRule be called lineSpacing?

[Basca]

Hey georgbachmann,

There is indeed something going wrong with LineSpacing not being correctly set for Lists.
After some more investigating based on your remarks I found that starting from #63 the lineHeight has been added, but no default implementation has been added.

We will look further into this, to see what is more clear naming wise and how this should be setup.