Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the ability to blocking flush after a bootstrap #269

Closed
robskillington opened this issue Feb 16, 2017 · 0 comments
Closed

Add back the ability to blocking flush after a bootstrap #269

robskillington opened this issue Feb 16, 2017 · 0 comments
Assignees

Comments

@robskillington
Copy link
Collaborator

The following PR works around an issue we encountered when naively trying to flush after a bootstrap:
#268

It does this by simply waiting for the next tick and a flush to occur to actually finish the bootstrap process.

Ideally we do actually flush directly after a bootstrap, however we need to coordinate with the ticking procedure to ensure that all buffers have been rotated into each series by waiting for a tick to rotate all the buffers before we can start a flush cycle (otherwise me miss blocks that are just about to rotate in for that time window when we flush and we don't flush them again because the time window is marked flushed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants