Don't flush data during bootstrapping #268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @robskillington @cw9 @prateek @ben-lerner
This PR addresses an issue where we used to flush data at the end of bootstrapping but not drain the buffer for the most recent 2-hour block, causing them not to be flushed to filesystem and permanent lost due to interaction with block retrieval manager.
This PR temporarily disables data flushing during bootstrapping, a longer-term fix will be in an upcoming PR shortly.