Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proto] Add Prometheus Protobuf definitions to support annotations #2029

Merged
merged 2 commits into from Oct 30, 2019

Conversation

jeromefroe
Copy link
Collaborator

@jeromefroe jeromefroe commented Oct 30, 2019

What this PR does / why we need it:

This PR adds Protobuf definitions for annotated datapoints to the m3prometheus package. These types will be part of an experimental API for supporting exemplars. I chose to create new types instead of augmenting the existing Sample type because support for annotations will be experimental to start and may undergo significant revisions. Introducing a new type may result in some code duplication but will help us ensure that the changes we make for annotations can be independent from the established types for Prometheus remote read and write.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #2029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2029   +/-   ##
======================================
  Coverage    72.3%   72.3%           
======================================
  Files        1003    1003           
  Lines       86612   86612           
======================================
  Hits        62659   62659           
  Misses      19730   19730           
  Partials     4223    4223
Flag Coverage Δ
#aggregator 82.1% <0%> (ø) ⬆️
#cluster 84.3% <0%> (ø) ⬆️
#collector 63.7% <0%> (ø) ⬆️
#dbnode 51.6% <0%> (ø) ⬆️
#m3em 53.3% <0%> (ø) ⬆️
#m3ninx 69.4% <0%> (ø) ⬆️
#m3nsch 49% <0%> (ø) ⬆️
#metrics 29.2% <0%> (ø) ⬆️
#msg 74.9% <0%> (ø) ⬆️
#query 68.9% <0%> (ø) ⬆️
#x 83.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1461ce6...b1e08c1. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #2029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2029   +/-   ##
======================================
  Coverage    72.3%   72.3%           
======================================
  Files        1004    1004           
  Lines       86613   86613           
======================================
  Hits        62671   62671           
  Misses      19720   19720           
  Partials     4222    4222
Flag Coverage Δ
#aggregator 74.1% <0%> (ø) ⬆️
#cluster 83.7% <0%> (ø) ⬆️
#collector 63.5% <0%> (ø) ⬆️
#dbnode 51.6% <0%> (ø) ⬆️
#m3em 53.3% <0%> (ø) ⬆️
#m3ninx 69.4% <0%> (ø) ⬆️
#m3nsch 49% <0%> (ø) ⬆️
#metrics 29.2% <0%> (ø) ⬆️
#msg 74.9% <0%> (ø) ⬆️
#query 68.9% <0%> (ø) ⬆️
#x 83.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1461ce6...b1e08c1. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #2029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2029   +/-   ##
======================================
  Coverage    72.8%   72.8%           
======================================
  Files        1006    1006           
  Lines       86164   86164           
======================================
  Hits        62742   62742           
  Misses      19211   19211           
  Partials     4211    4211
Flag Coverage Δ
#aggregator 72% <0%> (ø) ⬆️
#cluster 40.2% <0%> (ø) ⬆️
#collector 68.9% <0%> (ø) ⬆️
#dbnode 75.5% <0%> (ø) ⬆️
#m3em 72.7% <0%> (ø) ⬆️
#m3ninx 15% <0%> (ø) ⬆️
#m3nsch 46.6% <0%> (ø) ⬆️
#metrics 56.7% <0%> (ø) ⬆️
#msg 74.9% <0%> (ø) ⬆️
#query 60.7% <0%> (ø) ⬆️
#x 67.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9906249...65adc1b. Read the comment docs.

@jeromefroe jeromefroe force-pushed the jeromefroe/support-writing-annotated-datapoints branch from b1e08c1 to 9503d54 Compare October 30, 2019 15:10
@robskillington
Copy link
Collaborator

That sounds like a sane approach.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromefroe jeromefroe merged commit ee24d35 into master Oct 30, 2019
@jeromefroe jeromefroe deleted the jeromefroe/support-writing-annotated-datapoints branch October 30, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants