[kv] Include key name in watch errors #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnikola
reviewed
Feb 10, 2020
src/x/watch/value.go
Outdated
| v.Unlock() | ||
| continue | ||
| } | ||
| if err = v.processWithLockFn(update); err != nil { | ||
| v.log.Error("error updating update", zap.Error(err)) | ||
| v.log.Error("error updating update", |
There was a problem hiding this comment.
nit: "error applying update"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Ensures that all watch errors will include the key they're watching. Sometimes loggers have enough context to include this error, but not always. Should make watch errors less ambiguous.
This doesn't fully fix the problem as we don't have access to the raw etcd key, but should make some cases less difficult to debug.
Before:
{"level":"fatal","ts":1581361983.0189734,"msg":"error creating aggregator options","error":"initializing value error:init watch timeout"}After:
{"level":"fatal","ts":1581362476.4911253,"msg":"error creating aggregator options","error":"initializing value error (key='m3aggregator'): init watch timeout"}Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: