Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Allow to change default sysctl parameters using environment variables #3689

Merged
merged 4 commits into from Sep 10, 2021

Conversation

aivarasko
Copy link
Contributor

When using a higher number of shards current limit of 3M files limit is not enough.

Make these parameters configurable for docker based environments by allowing change using env variables.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #3689 (6b5c855) into master (6b5c855) will not change coverage.
The diff coverage is n/a.

❗ Current head 6b5c855 differs from pull request most recent head c794ca5. Consider uploading reports for the commit c794ca5 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3689   +/-   ##
======================================
  Coverage    56.9%   56.9%           
======================================
  Files         552     552           
  Lines       62950   62950           
======================================
  Hits        35853   35853           
  Misses      23914   23914           
  Partials     3183    3183           
Flag Coverage Δ
aggregator 63.2% <0.0%> (ø)
cluster ∅ <0.0%> (∅)
collector 58.4% <0.0%> (ø)
dbnode 60.6% <0.0%> (ø)
m3em 46.4% <0.0%> (ø)
metrics 19.7% <0.0%> (ø)
msg 74.4% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5c855...c794ca5. Read the comment docs.

Copy link
Collaborator

@schallert schallert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schallert schallert merged commit cffe04d into m3db:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants